Re: [PATCH] format-patch: generate valid patch with diff.noprefix config

Laurent Arnoud [off-list ref] writes:

With diff.noprefix enabled the patch generated with format-patch does not
include prefix a/ and b/ so not applicable with `git am`.

Some projects (not this one) do not want to see a/ and b/ prefix in
their patches, and noprefix is an option for those who needs to give
patches to such projects.  As "am" can be told with -p<num> to accept
such a patch just fine, I do not think this change is appropriate.

Solution is to force a_prefix and b_prefix on diffopt.

Sorry, I do not think there is any problem to be solved here ;-)

On Tue, Jun 02, 2020 at 02:12:37PM -0700, Junio C Hamano wrote:

Some projects (not this one) do not want to see a/ and b/ prefix in
their patches, and noprefix is an option for those who needs to give
patches to such projects.  As "am" can be told with -p<num> to accept
such a patch just fine, I do not think this change is appropriate.

quoted

Solution is to force a_prefix and b_prefix on diffopt.

Sorry, I do not think there is any problem to be solved here ;-)

Haha I see thanks for the explanations

-- 
Laurent