Re: What's cooking in git.git (Mar 2020, #01; Tue, 3)

2 messages, 2 authors, 2020-03-03 · open the first message on its own page

Re: What's cooking in git.git (Mar 2020, #01; Tue, 3)

From: Junio C Hamano <hidden>
Date: 2020-03-03 23:19:44

Junio C Hamano [off-list ref] writes:
Taylor Blau [off-list ref] writes:
quoted
What's in 'v3' of that series [1] is ready to merge, in my opinion.
Alright.  Let's do so.
quoted
[1]: https://lore.kernel.org/git/cover.1581486293.git.me@ttaylorr.com/#t
Thanks.
Hmph, actually...
It was intended as the former, but I share both of your feelings that it
could be read either way. I amended the commit message to clarify by
adding:

  (and haven't since been deleted from the object store)

as a parenthetical after "already in the graph...".
... don't we want to get that "amended" one, at least?  I do not
recall if there were other things you said you'd tweak or not during
the review of that v3, though.

Re: What's cooking in git.git (Mar 2020, #01; Tue, 3)

From: Taylor Blau <hidden>
Date: 2020-03-03 23:28:29

On Tue, Mar 03, 2020 at 03:19:38PM -0800, Junio C Hamano wrote:
Junio C Hamano [off-list ref] writes:
quoted
Taylor Blau [off-list ref] writes:
quoted
What's in 'v3' of that series [1] is ready to merge, in my opinion.
Alright.  Let's do so.
quoted
[1]: https://lore.kernel.org/git/cover.1581486293.git.me@ttaylorr.com/#t
Thanks.
Hmph, actually...
quoted
It was intended as the former, but I share both of your feelings that it
could be read either way. I amended the commit message to clarify by
adding:

  (and haven't since been deleted from the object store)

as a parenthetical after "already in the graph...".
... don't we want to get that "amended" one, at least?  I do not
recall if there were other things you said you'd tweak or not during
the review of that v3, though.
I couldn't quite find where this amended version went, so I recreated it
and sent it as
7c47f37122ff2b03f0bccc48cb6ca022904f6353.1583278022.git.me@ttaylorr.com.

Thanks.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help