Re: [PATCH v3] add: use advice API to display hints

Heba Waly [off-list ref] writes:

On Fri, Jan 31, 2020 at 10:59 AM Junio C Hamano [off-list ref] wrote:

quoted

"Heba Waly via GitGitGadget" [off-list ref] writes:

quoted

From: Heba Waly <redacted>

In the "add" command, use the advice API to display hints to users,
as it provides a neat and a standard format for hint messages, and
the message visibility will be configurable.

Signed-off-by: Heba Waly <redacted>
---
    [Outreachy] add: use advise API to display hints

    In the "add" command, use the advice API to display hints to users, as
    it provides a neat and a standard format for hint messages, and the
    message visibility will be configurable.

The topic has been in 'next' for the past week or so already.  If we
need to make further changes, please do so incrementally.

Will do, thanks.

I was reviewing the draft of the "What's cooking" report and noticed
that this update is not there---did I miss one?

Thanks.

No, I agreed with my mentors to wait on this update until that branch
is merged in master.
So no need to worry about it.

Thanks,
Heba

On Thu, Feb 6, 2020 at 10:18 AM Junio C Hamano [off-list ref] wrote:

Heba Waly [off-list ref] writes:

quoted

On Fri, Jan 31, 2020 at 10:59 AM Junio C Hamano [off-list ref] wrote:

quoted

"Heba Waly via GitGitGadget" [off-list ref] writes:

quoted

From: Heba Waly <redacted>

In the "add" command, use the advice API to display hints to users,
as it provides a neat and a standard format for hint messages, and
the message visibility will be configurable.

Signed-off-by: Heba Waly <redacted>
---
    [Outreachy] add: use advise API to display hints

    In the "add" command, use the advice API to display hints to users, as
    it provides a neat and a standard format for hint messages, and the
    message visibility will be configurable.

The topic has been in 'next' for the past week or so already.  If we
need to make further changes, please do so incrementally.

Will do, thanks.

I was reviewing the draft of the "What's cooking" report and noticed
that this update is not there---did I miss one?

Thanks.