Re: [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision

Derrick Stolee [off-list ref] writes:

On 12/17/2019 10:28 PM, Philippe Blain wrote:

quoted

quoted

Le 17 déc. 2019 à 13:16, Junio C Hamano [off-list ref] a écrit :
Even when you specify <start> or <end> as a line number, they must
exist in the starting revision or it would be a fatal error.  If we
are clarifying with this patch for completeness, I think we should
also mention it together.  

...

quoted

    git log -L 300,2000000085:Documentation/git-log.txt 
errors out:
    fatal: file Documentation/git-log.txt has only 239 lines

This case seems important enough to include what it means to "match".

Yup, that is why I suggested not to focus too much on regexp and
"match"-ing, but express it in terms of the lines that are specified
by given arguments to "exist".  The word "match" gives an incorrect
connotation that the description in the paragraph that uses the verb
applies only to regexp.

Le 18 déc. 2019 à 12:59, Junio C Hamano [off-list ref] a écrit :
...
Yup, that is why I suggested not to focus too much on regexp and
"match"-ing, but express it in terms of the lines that are specified
by given arguments to "exist".  The word "match" gives an incorrect
connotation that the description in the paragraph that uses the verb
applies only to regexp.

I agree. Thanks for the suggestion. I changed it to « exist » in v2.