2 messages, 2 authors, 2019-11-14 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2019-11-14 02:25:10
"Ben Keene via GitGitGadget" [off-list ref] writes:
commit: git-p4.py: Cast byte strings to unicode strings in python3
Luke, this patch [*1*] came in my way, but I am hardly an expert on Py2to3 and know nothing about P4. Could you take a look at them, please? Thanks. [References] [off-list ref]
From: Luke Diamand <hidden>
Date: 2019-11-14 09:46:33
On Thu, 14 Nov 2019 at 02:25, Junio C Hamano [off-list ref] wrote:
"Ben Keene via GitGitGadget" [off-list ref] writes:quoted
commit: git-p4.py: Cast byte strings to unicode strings in python3Luke, this patch [*1*] came in my way, but I am hardly an expert on Py2to3 and know nothing about P4. Could you take a look at them, please? Thanks. [References] [off-list ref]
I just quickly tried it, and with git-p4 switched to using python3, the unit tests fail. $ make -C t T=t98* But it looks like a reasonable approach, and with the demise of Python2 fast approaching it would be good to get this fully working! Luke