[PATCH] Specify -Wformat along with -Wformat-security

Subsystems: the rest

STALE2807d

3 messages, 2 authors, 2018-12-27 · open the first message on its own page

[PATCH] Specify -Wformat along with -Wformat-security

From: Masaya Suzuki <hidden>
Date: 2018-12-27 06:59:09

Without -Wformat, -Wformat-security won't work.
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Signed-off-by: Masaya Suzuki <redacted>
---
 config.mak.dev | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.mak.dev b/config.mak.dev
index bbeeff44f..aae9db67d 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -7,6 +7,7 @@ CFLAGS += -pedantic
 CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
 endif
 CFLAGS += -Wdeclaration-after-statement
+CFLAGS += -Wformat
 CFLAGS += -Wformat-security
 CFLAGS += -Wno-format-zero-length
 CFLAGS += -Wold-style-definition
-- 
2.20.1.415.g653613c723-goog

Re: [PATCH] Specify -Wformat along with -Wformat-security

From: Duy Nguyen <hidden>
Date: 2018-12-27 18:36:20

On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki [off-list ref] wrote:
Without -Wformat, -Wformat-security won't work.
quoted
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Compiler name and version?
quoted hunk
Signed-off-by: Masaya Suzuki <redacted>
---
 config.mak.dev | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.mak.dev b/config.mak.dev
index bbeeff44f..aae9db67d 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -7,6 +7,7 @@ CFLAGS += -pedantic
 CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
 endif
 CFLAGS += -Wdeclaration-after-statement
+CFLAGS += -Wformat
 CFLAGS += -Wformat-security
 CFLAGS += -Wno-format-zero-length
 CFLAGS += -Wold-style-definition
--
2.20.1.415.g653613c723-goog

-- 
Duy

Re: [PATCH] Specify -Wformat along with -Wformat-security

From: Masaya Suzuki <hidden>
Date: 2018-12-27 18:46:49

On Thu, Dec 27, 2018 at 10:36 AM Duy Nguyen [off-list ref] wrote:
On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki [off-list ref] wrote:
quoted
Without -Wformat, -Wformat-security won't work.
quoted
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Compiler name and version?
I'm not familar with the tools, so please be patient.

According to Makefile, `CC = cc`. With `cc --version`, it says:

cc (Debian 7.3.0-5) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Jonathan said there was the same patch. Looks like
https://public-inbox.org/git/20181012184037.15076-1-t.gummerer@gmail.com/.
I'll check my config again.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help