# Re: \[PATCH 0/3\] doc-diff: add "clean" mode \& fix portability problem

- From: Junio C Hamano \<hidden\>
- Date: 2018-08-31 18:49:49 
- List: git
- Page: https://ratatoskr.run/git/2018/08/7782921
- Thread: https://ratatoskr.run/git/2018/08/7782921/t.md

```text
Eric Sunshine [ref] writes:

> This series replaces Peff's solo patch[1] which updates "make clean" to
> remove doc-diff's temporary directory. Rather than imbuing the Makefile
> with knowledge specific to doc-diff's internals, this series adds a
> "clean" mode to doc-diff which removes its temporary worktree and
> generated files, and has "make clean" invoke that instead.

That sounds like a better approach.

> It also fixes
> a portability problem which prevented doc-diff from working on MacOS and
> FreeBSD.
>
> [1]: https://public-inbox.org/git/20180830195546.GA22407@sigill.intra.peff.net/
>
> Eric Sunshine (3):
>   doc-diff: fix non-portable 'man' invocation
>   doc-diff: add --clean mode to remove temporary working gunk
>   doc/Makefile: drop doc-diff worktree and temporary files on "make
>     clean"
>
>  Documentation/Makefile |  1 +
>  Documentation/doc-diff | 21 +++++++++++++++++----
>  2 files changed, 18 insertions(+), 4 deletions(-)
```