Question on range-diff and notes.displayref

From: Elijah Newren <hidden>
Date: 2018-07-31 17:19:18

Should git notes show up in a range-diff?  I happened to have
    notes.displayref=refs/notes/amlog
set in my git.git repo, and saw the below in my range-diff:

On Tue, Jul 31, 2018 at 10:12 AM, Elijah Newren [off-list ref] wrote:
1:  4a1c9c3368 ! 1:  00f94a8b41 t1015: demonstrate directory/file conflict recovery failures
    @@ -14,7 +14,6 @@

         Signed-off-by: Elijah Newren [off-list ref]
         Signed-off-by: Junio C Hamano [off-list ref]
    -    Message-Id: [ref]

     diff --git a/t/t1015-read-index-unmerged.sh b/t/t1015-read-index-unmerged.sh
     new file mode 100755
2:  e105e8bfbd ! 2:  d3b8d7edb6 read-cache: fix directory/file conflict handling in read_index_unmerged()
    @@ -59,7 +59,6 @@

         Signed-off-by: Elijah Newren [off-list ref]
         Signed-off-by: Junio C Hamano [off-list ref]
    -    Message-Id: [ref]
<snip>


Maybe this is expected or wanted (tbdiff also shows the git notes for
what it's worth), but it seemed somewhat surprising to me.  I'd rather
not see such "differences" displayed for the patch series that I'm
submitting, but perhaps others see it differently?

Elijah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help