Оля Тележная [off-list ref] writes:
2018-07-26 1:13 GMT+03:00 Junio C Hamano [off-list ref]:
quoted
* ot/ref-filter-object-info (2018-07-17) 5 commits
- ref-filter: use oid_object_info() to get object
- ref-filter: merge get_obj and get_object
- ref-filter: initialize eaten variable
- ref-filter: fill empty fields with empty values
- ref-filter: add info_source to valid_atom
A few atoms like %(objecttype) and %(objectsize) in the format
specifier of "for-each-ref --format=<format>" can be filled without
getting the full contents of the object, but just with the object
header. These cases have been optimzied by calling
oid_object_info() API.
What's the doneness of this one?
It is ready. Thanks.
Thanks, the question was meant more to the reviewers and mentors
than the original author, though ;-)
On Thu, Jul 26, 2018 at 6:57 PM, Junio C Hamano [off-list ref] wrote:
Оля Тележная [off-list ref] writes:
quoted
2018-07-26 1:13 GMT+03:00 Junio C Hamano [off-list ref]:
quoted
* ot/ref-filter-object-info (2018-07-17) 5 commits
- ref-filter: use oid_object_info() to get object
- ref-filter: merge get_obj and get_object
- ref-filter: initialize eaten variable
- ref-filter: fill empty fields with empty values
- ref-filter: add info_source to valid_atom
A few atoms like %(objecttype) and %(objectsize) in the format
specifier of "for-each-ref --format=<format>" can be filled without
getting the full contents of the object, but just with the object
header. These cases have been optimzied by calling
oid_object_info() API.
What's the doneness of this one?
It is ready. Thanks.
Thanks, the question was meant more to the reviewers and mentors
than the original author, though ;-)
I just tested this patch series on git.git on my laptop with the following:
$ time git for-each-ref --format='%(objecttype)' >/dev/null
and the best I can get without it is:
real 0m0,038s
user 0m0,034s
sys 0m0,004s
while with it I can get:
real 0m0,017s
user 0m0,016s
sys 0m0,000s
The results are similar with --format='%(objectsize)'.
So I think it is a nice improvement.
Looking at the code of the patches again, I can't see any simple way
to improve on the way it is done.
Thanks,
Christian.