[re-adding cc:git]
On Fri, Jul 20, 2018 at 12:38 AM Evgeny Cherpak [off-list ref] wrote:
quoted
On 20 Jul 2018, at 7:30, Eric Sunshine [off-list ref] wrote:
On Fri, Jul 20, 2018 at 12:11 AM Evgeny Cherpak [off-list ref] wrote:
quoted
Not sure what you referring to?
Is it alternative to gitk? How I install it?
This: https://git-scm.com/docs/git-gui
It's not an alternative to gitk, but complements it by providing
ability to stage and create commits, show blame information
graphically, etc.
It's a standard part of the Git distribution, although it may not be
installed by default, depending upon your platform and the packager.
Some Linux distributions, for instance, may place it in a separate
package for installation (named "git-gui" or something).
Just tried it - it works, but doesn't get focus.
Looking more closely, the code in "git gui" is catching and silently
ignoring errors:
## On Mac, bring the current Wish process window to front
if {[tk windowingsystem] eq "aqua"} {
catch {
exec osascript -e [format {
tell application "System Events"
set frontmost of processes whose unix id is %d to true
end tell
} [pid]]
}
}
which explains why you don't see the "Not authorized to send Apple
events" error you see with gitk, and also explains why the application
doesn't get focus.
So, updating gitk to mirror git-gui might be one way forward.
👍
On 20 Jul 2018, at 9:25, Eric Sunshine [off-list ref] wrote:
[re-adding cc:git]
On Fri, Jul 20, 2018 at 12:38 AM Evgeny Cherpak [off-list ref] wrote:
quoted
quoted
On 20 Jul 2018, at 7:30, Eric Sunshine [off-list ref] wrote:
On Fri, Jul 20, 2018 at 12:11 AM Evgeny Cherpak [off-list ref] wrote:
quoted
Not sure what you referring to?
Is it alternative to gitk? How I install it?
This: https://git-scm.com/docs/git-gui
It's not an alternative to gitk, but complements it by providing
ability to stage and create commits, show blame information
graphically, etc.
It's a standard part of the Git distribution, although it may not be
installed by default, depending upon your platform and the packager.
Some Linux distributions, for instance, may place it in a separate
package for installation (named "git-gui" or something).
Just tried it - it works, but doesn't get focus.
Looking more closely, the code in "git gui" is catching and silently
ignoring errors:
## On Mac, bring the current Wish process window to front
if {[tk windowingsystem] eq "aqua"} {
catch {
exec osascript -e [format {
tell application "System Events"
set frontmost of processes whose unix id is %d to true
end tell
} [pid]]
}
}
which explains why you don't see the "Not authorized to send Apple
events" error you see with gitk, and also explains why the application
doesn't get focus.
So, updating gitk to mirror git-gui might be one way forward.
On MacOS, a "wish" application started from the terminal opens in the
background, thus doesn't match user expectation that a newly-launched
application ought to be placed in the foreground. To address this
shortcoming, both gitk and git-gui use Apple Events to send a message to
"System Events" instructing it to foreground the "wish" application by
PID.
Unfortunately, MacOS 10.14 tightens restrictions on Apple Events,
requiring explicit granting of permission to control applications in
this fashion, and apparently such granting for "Automation" is not
allowed at all[1]. As a consequence gitk crashes outright at launch time
with a "Not authorized to send Apple events to System Events" error,
thus is entirely unusable on "Mojave".
In contrast, git-gui does not crash since it deliberately[2] catches and
ignores Apple Events errors. This does mean that git-gui will not
automatically become the foreground application on "Mojave", which is a
minor inconvenience but far better than crashing outright as gitk does.
Update gitk to catch and ignore Apple Events errors, mirroring git-gui's
behavior, to avoid this crash.
(Finding and implementing an alternate approach to foregrounding the
"wish" application on "Mojave" may be desirable but is outside the scope
of this crash fix.)
[1]: https://public-inbox.org/git/D295145E-7596-4409-9681-D8ADBB9EBB0C@me.com/
[2]: https://public-inbox.org/git/CABNJ2G+h3zh+=wLA0KHjUn8TsfhqUK1Kn-1_=6hnXVRJUPhuuA@mail.gmail.com/
Reported-by: Evgeny Cherpak <redacted>
Signed-off-by: Eric Sunshine <redacted>
---
Lack of 'catch' in the 'osascript' invocation in gitk was recognized as
a potential problem as far back as June 2013 [3,4]; now it's biting
"Mojave" users, making gitk unusable.
[3]: https://public-inbox.org/git/7vk3m7yukc.fsf@alter.siamese.dyndns.org/
[4]: https://public-inbox.org/git/1l424u5.uk987q18u3oxfM%25lists@haller-berlin.de/
gitk-git/gitk | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index a14d7a16b2..f13d1807bb 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -12210,11 +12210,13 @@ if {[catch {package require Tk 8.4} err]} {
# on OSX bring the current Wish process window to front
if {[tk windowingsystem] eq "aqua"} {
- exec osascript -e [format {
- tell application "System Events"
- set frontmost of processes whose unix id is %d to true
- end tell
- } [pid] ]
+ catch {
+ exec osascript -e [format {
+ tell application "System Events"
+ set frontmost of processes whose unix id is %d to true
+ end tell
+ } [pid] ]
+ }
}
# Unset GIT_TRACE var if set--
2.18.0.345.g5c9ce644c3