Re: [PATCH] sequencer.c: terminate the last line of author-scriptproperly

1 message, 1 author, 2018-07-18 · open the first message on its own page

Re: [PATCH] sequencer.c: terminate the last line of author-scriptproperly

From: Junio C Hamano <hidden>
Date: 2018-07-18 17:25:01

Phillip Wood [off-list ref] writes:
quoted
The only consumer of a faulty author script written by the sequencer
is read_env_script() in sequencer.c which doesn't worry about
checking that quotes are paired. 
That's not quite true anymore, recently another consumer
read_author_ident() was added which uses sq_dequote() instead of
custom code. Looking more closely at write_author_script() the quoting
of single quotes is buggy they are escaped as \\' instead of \'.
That's embarrassing re-invention (instead of reuse) with additional
bug X-<.  It seems that all of that blame to d87d48b2 ("sequencer:
learn about the special "fake root commit" handling", 2018-05-04).

We should fix both broken writer and readers that compensate for
breakage in the writer, I guess.  Sigh...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help