Re: [GSoC][PATCH v5 0/3] rebase -i: rewrite reflog operations in C

Junio C Hamano [off-list ref] writes:

Let's aggregate these topics into a single topic, and perhaps call
it ag/rebase-i-in-c or something like that.  Pretending as if they
are separately replaceable does not make much sense, as you are not
rerolling the earlier one and keep going forward with producing more
parts that depends on the parts that have been submitted earlier.

So here is what I tentatively did.

    $ git log --oneline --reverse master..ag/rebase-i-in-c
    4d303fb608 rebase--interactive: rewrite append_todo_help() in C
    b4ffe143a9 editor: add a function to launch the sequence editor
    4ebe39cef9 rebase--interactive: rewrite the edit-todo functionality in C
    0ff6bf7646 sequencer: add a new function to silence a command, except if it fails.
    36784b351f rebase -i: rewrite setup_reflog_action() in C
    415cac57ee rebase -i: rewrite checkout_onto() in C

In several hours please fetch from me and look for "Merge branch
'ag/rebase-i-in-c' to pu" to see how they exactly look like; some of
the patches might not be the latest ones, in which case you may need
to prod me to get them replaced (resending them as a whole with
incremented v$n header is probably the easiest if we need to do so).

Thanks.

Hi Junio,

Le 29/06/2018 à 20:23, Junio C Hamano a écrit :

Junio C Hamano [off-list ref] writes:

quoted

Let's aggregate these topics into a single topic, and perhaps call
it ag/rebase-i-in-c or something like that.  Pretending as if they
are separately replaceable does not make much sense, as you are not
rerolling the earlier one and keep going forward with producing more
parts that depends on the parts that have been submitted earlier.

So here is what I tentatively did.

    $ git log --oneline --reverse master..ag/rebase-i-in-c
    4d303fb608 rebase--interactive: rewrite append_todo_help() in C
    b4ffe143a9 editor: add a function to launch the sequence editor
    4ebe39cef9 rebase--interactive: rewrite the edit-todo functionality in C
    0ff6bf7646 sequencer: add a new function to silence a command, except if it fails.
    36784b351f rebase -i: rewrite setup_reflog_action() in C
    415cac57ee rebase -i: rewrite checkout_onto() in C

In several hours please fetch from me and look for "Merge branch
'ag/rebase-i-in-c' to pu" to see how they exactly look like; some of
the patches might not be the latest ones, in which case you may need
to prod me to get them replaced (resending them as a whole with
incremented v$n header is probably the easiest if we need to do so).

Thanks.

The patches about append_todo_help() and edit-todo are not up to date,
so I’ll resend them in a few minutes.  Otherwise, this looks good to me.

Cheers,
Alban