[PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR

Subsystems: the rest · Maintainer: Linus Torvalds

STALE3069d

2 messages, 2 authors, 2018-06-03 · open the first message on its own page

[PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR

From: Robert P. J. Day <hidden>
Date: 2018-06-03 12:24:24

Fix single misspelling of $GITDIR to correct $GIT_DIR.

Signed-off-by: Robert P. J. Day <redacted>

---

only occurrence in entire code base that i ran across, so i figured
might as well fix it.

diff --git a/sha1-file.c b/sha1-file.c
index 555e780f4..695e5c627 100644
--- a/sha1-file.c
+++ b/sha1-file.c

@@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
 /*
  * Compute the exact path an alternate is at and returns it. In case of
  * error NULL is returned and the human readable error is added to `err`
- * `path` may be relative and should point to $GITDIR.
+ * `path` may be relative and should point to $GIT_DIR.
  * `err` must not be null.
  */
 char *compute_alternate_path(const char *path, struct strbuf *err)

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR

From: SZEDER Gábor <hidden>
Date: 2018-06-03 14:29:26

Could you please add "in a comment" to the end of the subject line?
So it will be immediately clear to future readers of 'git log
--oneline' that this is not a bugfix.

quoted hunk

Fix single misspelling of $GITDIR to correct $GIT_DIR.

Signed-off-by: Robert P. J. Day <redacted>

---

only occurrence in entire code base that i ran across, so i figured
might as well fix it.

diff --git a/sha1-file.c b/sha1-file.c
index 555e780f4..695e5c627 100644
--- a/sha1-file.c
+++ b/sha1-file.c

@@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
 /*
  * Compute the exact path an alternate is at and returns it. In case of
  * error NULL is returned and the human readable error is added to `err`
- * `path` may be relative and should point to $GITDIR.
+ * `path` may be relative and should point to $GIT_DIR.
  * `err` must not be null.
  */
 char *compute_alternate_path(const char *path, struct strbuf *err)

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help