Re: [PATCH] branch: issue "-l" deprecation warning after pager starts

2 messages, 2 authors, 2018-05-31 · open the first message on its own page

Re: [PATCH] branch: issue "-l" deprecation warning after pager starts

From: Junio C Hamano <hidden>
Date: 2018-05-30 02:48:39

Jeff King [off-list ref] writes:
quoted
-		if (list) {
-			warning("the '-l' option is an alias for '--create-reflog' and");
-			warning("has no effect in list mode. This option will soon be");
-			warning("removed and you should omit it (or use '--list' instead).");
-		} else {
-			warning("the '-l' alias for '--create-reflog' is deprecated;");
-			warning("it will be removed in a future version of Git");
-		}
-	}
-
Oh, and did we want to mark these for translation on the step 0 branch?
Obviously that would impact this hunk.
I was hoping that we can settle the "multi-line message translation
that can potentially result in different number of lines" issue
before we have to mark the above for translation ;-)

Re: [PATCH] branch: issue "-l" deprecation warning after pager starts

From: Jeff King <hidden>
Date: 2018-05-31 05:44:56

On Wed, May 30, 2018 at 11:48:32AM +0900, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
quoted
-		if (list) {
-			warning("the '-l' option is an alias for '--create-reflog' and");
-			warning("has no effect in list mode. This option will soon be");
-			warning("removed and you should omit it (or use '--list' instead).");
-		} else {
-			warning("the '-l' alias for '--create-reflog' is deprecated;");
-			warning("it will be removed in a future version of Git");
-		}
-	}
-
Oh, and did we want to mark these for translation on the step 0 branch?
Obviously that would impact this hunk.
I was hoping that we can settle the "multi-line message translation
that can potentially result in different number of lines" issue
before we have to mark the above for translation ;-)
Yeah, right after saying that I realized it would create horrible
translation-lego. I agree we should punt for now.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help