[PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning

Subsystems: the rest

STALE3056d

2 messages, 2 authors, 2018-05-30 · open the first message on its own page

[PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning

From: Ramsay Jones <hidden>
Date: 2018-05-29 20:01:55

Signed-off-by: Ramsay Jones <redacted>
---

Hi Derrick,

If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f),
could you please squash this into the relevant patch (commit 80453b4529,
"commit-graph: add 'verify' subcommand", 2018-05-24).

[No, No, that was the one in graph_read(). :-D ]

Thanks!

ATB,
Ramsay Jones

 builtin/commit-graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 20ce6437a..6abfde5e6 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -39,7 +39,7 @@ static struct opts_commit_graph {
 
 static int graph_verify(int argc, const char **argv)
 {
-	struct commit_graph *graph = 0;
+	struct commit_graph *graph = NULL;
 	char *graph_name;
 
 	static struct option builtin_commit_graph_verify_options[] = {
-- 
2.17.0

Re: [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning

From: Derrick Stolee <hidden>
Date: 2018-05-30 00:58:00

n 5/29/2018 4:01 PM, Ramsay Jones wrote:
Signed-off-by: Ramsay Jones <redacted>
---

Hi Derrick,

If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f),
could you please squash this into the relevant patch (commit 80453b4529,
"commit-graph: add 'verify' subcommand", 2018-05-24).

[No, No, that was the one in graph_read(). :-D ]
Thanks for helping rid me of my bad habits! I'll get this one in v4.
quoted hunk
Thanks!

ATB,
Ramsay Jones

  builtin/commit-graph.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 20ce6437a..6abfde5e6 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -39,7 +39,7 @@ static struct opts_commit_graph {
  
  static int graph_verify(int argc, const char **argv)
  {
-	struct commit_graph *graph = 0;
+	struct commit_graph *graph = NULL;
  	char *graph_name;
  
  	static struct option builtin_commit_graph_verify_options[] = {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help