Re: [PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

2 messages, 2 authors, 2018-05-12 · open the first message on its own page

Re: [PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

From: Junio C Hamano <hidden>
Date: 2018-05-12 13:43:45

Jeff King [off-list ref] writes:
On Sat, May 12, 2018 at 10:00:20AM +0200, Nguyễn Thái Ngọc Duy wrote:
quoted
+define_commit_slab(commit_seen, int);
Yay, this one is nice and simple. :) This is what I had hoped for all
along with the slab concept.

-Peff
Does it need to use a full int, not just a byte per commit, though?

Re: [PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

From: Duy Nguyen <hidden>
Date: 2018-05-12 14:00:50

On Sat, May 12, 2018 at 3:43 PM, Junio C Hamano [off-list ref] wrote:
Jeff King [off-list ref] writes:
quoted
On Sat, May 12, 2018 at 10:00:20AM +0200, Nguyễn Thái Ngọc Duy wrote:
quoted
+define_commit_slab(commit_seen, int);
Yay, this one is nice and simple. :) This is what I had hoped for all
along with the slab concept.

-Peff
Does it need to use a full int, not just a byte per commit, though?
True. Is it time to introduce 'bool' type? I did not want to put the
'char' type up there (but now that I think about it I could have put
uint8_t too).
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help