Re: [PATCH v2 00/17] document & test fetch pruning & add fetch.pruneTags

2 messages, 2 authors, 2018-02-09 · open the first message on its own page

Re: [PATCH v2 00/17] document & test fetch pruning & add fetch.pruneTags

From: Junio C Hamano <hidden>
Date: 2018-02-08 19:48:40

Ævar Arnfjörð Bjarmason [off-list ref] writes:
On Thu, Feb 08 2018, Ævar Arnfjörð Bjarmason jotted:
quoted
As noted in my 87h8quytmq.fsf@evledraar.gmail.com there was a bug I
noticed in v3 where it would segfault on some git-fetch invocations,
but there were not tests anywhere that caught that.
...and of course this whole submission this time around should be v4,
not v2, but I didn't notice that I didn't adjust the subject prefix
before sending. Junio: Hopefully you can pick it up anyway without too
much trouble, sorry.

FWIW I've deployed this to production @ work to some tens of k of
machines (low "k" of which have users using git) without any issues.
Will replace.  I found that the resolution of conflicts necessary
with the jh/partial-clone topic is a bit different from the previous
version due to addition of an extra parameter to fetch_one(), and I
think I didn't botch it, but please double check when I push the
results out in a few hours.

Thanks.

Re: [PATCH v2 00/17] document & test fetch pruning & add fetch.pruneTags

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2018-02-09 21:06:42

On Thu, Feb 08 2018, Junio C. Hamano jotted:
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
On Thu, Feb 08 2018, Ævar Arnfjörð Bjarmason jotted:
quoted
As noted in my 87h8quytmq.fsf@evledraar.gmail.com there was a bug I
noticed in v3 where it would segfault on some git-fetch invocations,
but there were not tests anywhere that caught that.
...and of course this whole submission this time around should be v4,
not v2, but I didn't notice that I didn't adjust the subject prefix
before sending. Junio: Hopefully you can pick it up anyway without too
much trouble, sorry.

FWIW I've deployed this to production @ work to some tens of k of
machines (low "k" of which have users using git) without any issues.
Will replace.  I found that the resolution of conflicts necessary
with the jh/partial-clone topic is a bit different from the previous
version due to addition of an extra parameter to fetch_one(), and I
think I didn't botch it, but please double check when I push the
results out in a few hours.
Thanks. FWIW I've looked over that resolution in pu and it LGTM.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help