RE: [PATCH v2 1/6] DO NOT APPLY Bypass GCC attributes on NonStop platform where used.

On January 19, 2018 3:29 PM, Ramsay Jones wrote:

On 19/01/18 17:34, randall.s.becker@rogers.com wrote:

quoted

From: "Randall S. Becker" <redacted>

* remote.c: force ignoring of GCC __attribute construct not supported
  by c99 by defining it as an empty CPP macro.

Signed-off-by: Randall S. Becker <redacted>
---
 remote.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/remote.c b/remote.c
index 4e93753e1..c18f9de7f 100644
--- a/remote.c
+++ b/remote.c

@@ -11,6 +11,10 @@
 #include "mergesort.h"
 #include "argv-array.h"

+#if defined (__TANDEM)
+#define __attribute(a)
+#endif
+

Hmm, the only use of __attribute() I can find is in compat/regex/.
In particular, there is no use of __attribute() in regex.c.
[__attribute__() is used in regex.c]

Is this an old patch which is no longer required?

puzzled.

After investigation, this patch can be dropped. The __attribute__ fix from git-compat-utils.h is actually being picked up correctly now (unlike our 2.8.5 port when it was required). I am suspecting that this was blocked by a configuration setting in config.mak.uname that got fixed when I got my hands on that file for a cleanup. The path through there is via #ifndef __GNUC__.

Cheers,
Randall