Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

Jeff King [off-list ref] writes:

On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote:

quoted

Signed-off-by: Junio C Hamano <redacted>
---

It might be worth mentioning why this conversion is pulled out from the
others (because its "default" case is "do not touch the pointer").

I am not sure what you mean by "pulled out from the others".  I did
not intend to keep these 3 additional patches permanently; rather, I
did them to help Christian's rerolling the series, and I do not think
this one should be separate from other ones that use the _default()
variant when that happens.

On Thu, Dec 07, 2017 at 01:59:39PM -0800, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote:

quoted

Signed-off-by: Junio C Hamano <redacted>
---

It might be worth mentioning why this conversion is pulled out from the
others (because its "default" case is "do not touch the pointer").

I am not sure what you mean by "pulled out from the others".  I did
not intend to keep these 3 additional patches permanently; rather, I
did them to help Christian's rerolling the series, and I do not think
this one should be separate from other ones that use the _default()
variant when that happens.

Ah, I see. I had thought you meant these to be applied on top.

-Peff