Re: [PATCH] diff: add tests for --relative without optional prefix value

Jeff King [off-list ref] writes:

On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:

quoted

From: Jacob Keller <redacted>

We already have tests for --relative, but they currently only test when
a prefix has been provided. This fails to test the case where --relative
by itself should use the current directory as the prefix.

Teach the check_$type functions to take a directory argument to indicate
which subdirectory to run the git commands in. Add a new test which uses
this to test --relative without a prefix value.

This looks good to me (and I slightly prefer it over Junio's for the
simplicity).

I agree on the ordering suggestion Junio made.

I also prefer this one over the other one, provided if it is ported
on top of the preliminary clean-up I did in the other one.

Thanks.

On Thu, Dec 7, 2017 at 1:50 PM, Junio C Hamano [off-list ref] wrote:

Jeff King [off-list ref] writes:

quoted

On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:

quoted

From: Jacob Keller <redacted>

We already have tests for --relative, but they currently only test when
a prefix has been provided. This fails to test the case where --relative
by itself should use the current directory as the prefix.

Teach the check_$type functions to take a directory argument to indicate
which subdirectory to run the git commands in. Add a new test which uses
this to test --relative without a prefix value.

This looks good to me (and I slightly prefer it over Junio's for the
simplicity).

I agree on the ordering suggestion Junio made.

I also prefer this one over the other one, provided if it is ported
on top of the preliminary clean-up I did in the other one.

Thanks.

Yea. I can do that if you want.

Thanks,
Jake