Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

4 messages, 3 authors, 2017-12-08 · open the first message on its own page

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Junio C Hamano <hidden>
Date: 2017-12-06 18:47:51

Johannes Sixt [off-list ref] writes:

The updated series works for me now. Nevertheless, I suggest to squash
in the following change to protect against IFS and globbing characters in
$INSTLIBDIR.

Yeah, that is very sensible.

quoted hunk

diff --git a/Makefile b/Makefile
index 7ac4458f11..08c78a1a63 100644
--- a/Makefile
+++ b/Makefile

@@ -2072,7 +2072,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
 	INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
 	INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
 	sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
-	    -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
+	    -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \
 	    -e 's=@@GITEXECDIR@@=$(gitexecdir_relative_SQ)=g' \
 	    -e 's=@@PERLLIBDIR@@=$(perllibdir_relative_SQ)=g' \
 	    $< >$@+ && \

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Daniel Jacques <hidden>
Date: 2017-12-06 18:57:06

On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano [off-list ref] wrote:

Johannes Sixt [off-list ref] writes:

quoted

The updated series works for me now. Nevertheless, I suggest to squash
in the following change to protect against IFS and globbing characters in
$INSTLIBDIR.

Yeah, that is very sensible.

quoted

diff --git a/Makefile b/Makefile
index 7ac4458f11..08c78a1a63 100644
--- a/Makefile
+++ b/Makefile

@@ -2072,7 +2072,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
      INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
      INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
      sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
-         -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
+         -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \
          -e 's=@@GITEXECDIR@@=$(gitexecdir_relative_SQ)=g' \
          -e 's=@@PERLLIBDIR@@=$(perllibdir_relative_SQ)=g' \
          $< >$@+ && \

Sounds good; I'll apply that to my working patch and include it in my
next ("v5") submission, which is currently blocked pending avarab@'s Perl
Makefile changes:
https://public-inbox.org/git/20171129195430.10069-1-avarab@gmail.com/T/#t

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2017-12-06 19:02:06

On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques [off-list ref] wrote:

On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano [off-list ref] wrote:

quoted

Johannes Sixt [off-list ref] writes:

quoted

The updated series works for me now. Nevertheless, I suggest to squash
in the following change to protect against IFS and globbing characters in
$INSTLIBDIR.

Yeah, that is very sensible.

quoted

diff --git a/Makefile b/Makefile
index 7ac4458f11..08c78a1a63 100644
--- a/Makefile
+++ b/Makefile

@@ -2072,7 +2072,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
      INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
      INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
      sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
-         -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
+         -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \
          -e 's=@@GITEXECDIR@@=$(gitexecdir_relative_SQ)=g' \
          -e 's=@@PERLLIBDIR@@=$(perllibdir_relative_SQ)=g' \
          $< >$@+ && \

Sounds good; I'll apply that to my working patch and include it in my
next ("v5") submission, which is currently blocked pending avarab@'s Perl
Makefile changes:
https://public-inbox.org/git/20171129195430.10069-1-avarab@gmail.com/T/#t

Thanks, FWIW I'll send another version of that at the end of the week
or so, I'm waiting to see if there's any more comments on it to reduce
list churn.

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2017-12-08 21:16:11

On Wed, Dec 06 2017, Ævar Arnfjörð Bjarmason jotted:

On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques [off-list ref] wrote:

quoted

On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano [off-list ref] wrote:

quoted

Johannes Sixt [off-list ref] writes:

quoted

The updated series works for me now. Nevertheless, I suggest to squash
in the following change to protect against IFS and globbing characters in
$INSTLIBDIR.

Yeah, that is very sensible.

quoted

diff --git a/Makefile b/Makefile
index 7ac4458f11..08c78a1a63 100644
--- a/Makefile
+++ b/Makefile

@@ -2072,7 +2072,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
      INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
      INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
      sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
-         -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
+         -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \
          -e 's=@@GITEXECDIR@@=$(gitexecdir_relative_SQ)=g' \
          -e 's=@@PERLLIBDIR@@=$(perllibdir_relative_SQ)=g' \
          $< >$@+ && \

Sounds good; I'll apply that to my working patch and include it in my
next ("v5") submission, which is currently blocked pending avarab@'s Perl
Makefile changes:
https://public-inbox.org/git/20171129195430.10069-1-avarab@gmail.com/T/#t

Thanks, FWIW I'll send another version of that at the end of the week
or so, I'm waiting to see if there's any more comments on it to reduce
list churn.

Sorry, I got this conflated with my sha1collisiondetection series, I
have nothing new to send out.

It seems everyone's happy with the version of my v2 (with Junio's
[off-list ref] on top) from this series,
so it's just a matter of waiting.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help