Re: [PATCH 1/5] p5550: factor our nonsense-pack creation

2 messages, 2 authors, 2017-11-23 · open the first message on its own page

Re: [PATCH 1/5] p5550: factor our nonsense-pack creation

From: Junio C Hamano <hidden>
Date: 2017-11-23 02:41:38

Jeff King [off-list ref] writes:
Right, I came to the same conclusion (we may even have discussed this on
the list, I don't remember). The current "todo" format says that only
the command and sha1 matter, and we'd be changing that. Maybe that's not
so bad if the user has to enable the feature themselves (and clearly it
would be incompatible with a custom format option).
If you are in the habit of always writing 4 or more lines, the
chance that you would make a typo on the line you can correct in the
"todo" list with such a feature is at most 25% ;-).

I think one downside is that a mere presence of such an option hints
that we somehow encourage people to commit with a title-only message.

Re: [PATCH 1/5] p5550: factor our nonsense-pack creation

From: Jeff King <hidden>
Date: 2017-11-23 05:02:21

On Thu, Nov 23, 2017 at 11:41:25AM +0900, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
Right, I came to the same conclusion (we may even have discussed this on
the list, I don't remember). The current "todo" format says that only
the command and sha1 matter, and we'd be changing that. Maybe that's not
so bad if the user has to enable the feature themselves (and clearly it
would be incompatible with a custom format option).
If you are in the habit of always writing 4 or more lines, the
chance that you would make a typo on the line you can correct in the
"todo" list with such a feature is at most 25% ;-).
You'd think, but the distribution of typos doesn't seem to be uniform.
:)

I think what actually happens is that I quite often do my final
proofread in my MUA, where the subject is displayed apart from the rest
of the message. So I tend to gloss over it, and any errors there are
more likely to make it to the list.
I think one downside is that a mere presence of such an option hints
that we somehow encourage people to commit with a title-only message.
Yeah, though it might be handy for me I think it just opens up too many
funny questions like this.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help