Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

2 messages, 2 authors, 2017-08-31 · open the first message on its own page

Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

From: Junio C Hamano <hidden>
Date: 2017-08-30 21:31:39

Torsten Bögershausen [off-list ref] writes:
How about something like this :

  This attribute sets a specific line-ending style to be used in the
  working directory.  It enables end-of-line conversion without any
 -content checks, effectively setting the `text` attribute.
 +content checks, effectively setting the `text` attribute.  Note that
 +setting this attribute on paths which are in the index with CRLF
 +line endings makes the paths to be considered dirty.
Is this "always makes them dirty" or "may make them dirty depending
on the situation"?  

If the latter, I'd prefer to see s/makes/may make/ here.

Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

From: Ben Boeckel <hidden>
Date: 2017-08-31 13:16:50

On Wed, Aug 30, 2017 at 14:31:30 -0700, Junio C Hamano wrote:
Is this "always makes them dirty" or "may make them dirty depending
on the situation"?  

If the latter, I'd prefer to see s/makes/may make/ here.
Yes, a coworker reported that some files slipped through this. New patch
incoming.

--Ben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help