[PATCH] sha1-lookup: remove sha1_entry_pos() from header file

Subsystems: the rest

STALE3263d

2 messages, 2 authors, 2017-08-25 · open the first message on its own page

[PATCH] sha1-lookup: remove sha1_entry_pos() from header file

From: Christian Couder <hidden>
Date: 2017-08-25 07:36:34

Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09)
the definition of sha1_entry_pos() has been removed from "sha1-lookup.c", so
there is no need anymore for its declaration in "sha1-lookup.h".

Signed-off-by: Christian Couder <redacted>
---
 sha1-lookup.h | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/sha1-lookup.h b/sha1-lookup.h
index 20af285681..cf5314f402 100644
--- a/sha1-lookup.h
+++ b/sha1-lookup.h
@@ -7,10 +7,4 @@ extern int sha1_pos(const unsigned char *sha1,
 		    void *table,
 		    size_t nr,
 		    sha1_access_fn fn);
-
-extern int sha1_entry_pos(const void *table,
-			  size_t elem_size,
-			  size_t key_offset,
-			  unsigned lo, unsigned hi, unsigned nr,
-			  const unsigned char *key);
 #endif
-- 
2.14.1.326.g3dc57ebfbd.dirty

Re: [PATCH] sha1-lookup: remove sha1_entry_pos() from header file

From: Jeff King <hidden>
Date: 2017-08-25 14:03:35

On Fri, Aug 25, 2017 at 09:36:13AM +0200, Christian Couder wrote:
Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09)
the definition of sha1_entry_pos() has been removed from "sha1-lookup.c", so
there is no need anymore for its declaration in "sha1-lookup.h".
Doh, thanks for catching.

Patch is obviously good.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help