Hi,
I recently found an issue with git-send-email where it does not
properly remove the cruft of an email address when sending using a Cc:
line.
The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+
which is the standard way Linux upstream expects the stable Ccs to be,
and I saw several examples of this in the past.
However, this gets converted into a cc of
"stable@vger.kernel.org#4.10+" which isn't a valid address obviously.
This does work as expected if you remember to
Cc: <redacted> # 4.10+
I would have assumed that validate_address would kick in and let me
know that the address I'd given isn't valid, or something along those
lines.
I tried to come up with a test for this, but modifying t9001 seemed to
cause other failures and I couldn't detangle exactly how the tests fit
together.
Is this simply expected behavior and I need to remember to use <>
around the address?
Thanks,
Jake
On Tue, Aug 22, 2017 at 4:15 PM, Jacob Keller [off-list ref] wrote:
Hi,
I recently found an issue with git-send-email where it does not
properly remove the cruft of an email address when sending using a Cc:
line.
The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+
Please see and discuss at
https://public-inbox.org/git/20170216174924.GB2625@localhost/
On Tue, Aug 22, 2017 at 4:18 PM, Stefan Beller [off-list ref] wrote:
On Tue, Aug 22, 2017 at 4:15 PM, Jacob Keller [off-list ref] wrote:
quoted
Hi,
I recently found an issue with git-send-email where it does not
properly remove the cruft of an email address when sending using a Cc:
line.
The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+
Please see and discuss at
https://public-inbox.org/git/20170216174924.GB2625@localhost/
I read that thread, and it addressed the problem of
Cc: <redacted> # 4.10+
but did not fix this case without the <> around the email address.
Additionally I just discovered that the behavior here changes pretty
drastically if you have Email::Validate installed, now it splits the
address into multiple things:
stable@vger.kernel.org, #, 4.10+
Thanks,
Jake
+cc people from that thread
On Tue, Aug 22, 2017 at 4:30 PM, Jacob Keller [off-list ref] wrote:
On Tue, Aug 22, 2017 at 4:18 PM, Stefan Beller [off-list ref] wrote:
quoted
On Tue, Aug 22, 2017 at 4:15 PM, Jacob Keller [off-list ref] wrote:
quoted
Hi,
I recently found an issue with git-send-email where it does not
properly remove the cruft of an email address when sending using a Cc:
line.
The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+
Please see and discuss at
https://public-inbox.org/git/20170216174924.GB2625@localhost/
I read that thread, and it addressed the problem of
Cc: <redacted> # 4.10+
but did not fix this case without the <> around the email address.
Additionally I just discovered that the behavior here changes pretty
drastically if you have Email::Validate installed, now it splits the
address into multiple things:
stable@vger.kernel.org, #, 4.10+
Thanks,
Jake