Stefan Beller [off-list ref] writes:
The svn specific declaration of repo_init was not used since 723b7a2789
(vcs-svn: eliminate repo_tree structure, 2010-12-10).
This was noticed when including repository.h via cache.h as that has the
same function with a different signature.
Helped-by: Jonathan Nieder [off-list ref]
Signed-off-by: Stefan Beller <redacted>
---
It looks to me that this is a reduced duplicate of what brian posted
yesterday. The first two patches in the 6-patch series that you
commented on, I think, covers what this change wants to achieve and
probably a lot more. I've merged those two already to 'next' and
was about to push the result out.
Thanks.
quoted hunk
vcs-svn/repo_tree.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h
index 889c6a3c95..8592beb59b 100644
--- a/vcs-svn/repo_tree.h
+++ b/vcs-svn/repo_tree.h
@@ -17,7 +17,6 @@ void repo_commit(uint32_t revision, const char *author,
const struct strbuf *log, const char *uuid, const char *url,
long unsigned timestamp);
void repo_diff(uint32_t r1, uint32_t r2);
-void repo_init(void);
void repo_reset(void);
#endif
On Tue, Aug 22, 2017 at 3:18 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:
quoted
The svn specific declaration of repo_init was not used since 723b7a2789
(vcs-svn: eliminate repo_tree structure, 2010-12-10).
This was noticed when including repository.h via cache.h as that has the
same function with a different signature.
Helped-by: Jonathan Nieder [off-list ref]
Signed-off-by: Stefan Beller <redacted>
---
It looks to me that this is a reduced duplicate of what brian posted
yesterday. The first two patches in the 6-patch series that you
commented on, I think, covers what this change wants to achieve and
probably a lot more. I've merged those two already to 'next' and
was about to push the result out.
Thanks.
Ok, thanks. I did not remember reviewing those.
(I just wanted to fix my odd compile error here,
and currently I build a series on top of jt/packmigrate
so I shot off a quick one liner)
Sorry for the noise.
Junio C Hamano wrote:
Stefan Beller [off-list ref] writes:
quoted
The svn specific declaration of repo_init was not used since 723b7a2789
(vcs-svn: eliminate repo_tree structure, 2010-12-10).
This was noticed when including repository.h via cache.h as that has the
same function with a different signature.
Helped-by: Jonathan Nieder [off-list ref]
Signed-off-by: Stefan Beller <redacted>
It looks to me that this is a reduced duplicate of what brian posted
yesterday. The first two patches in the 6-patch series that you
commented on, I think, covers what this change wants to achieve and
probably a lot more. I've merged those two already to 'next' and
was about to push the result out.
Thanks for the pointer. I believe you're referring to
https://public-inbox.org/git/20170821000022.26729-2-sandals@crustytoothpaste.net/.
From Stefan's verbal report I was about to send a patch just like
Brian's plus some more patches on top to get rid of the rest of repo_tree.h.
I can build on top of Brian's patch if that's more convenient.
Regards,
Jonathan
Junio C Hamano wrote:
Stefan Beller [off-list ref] writes:
quoted
The svn specific declaration of repo_init was not used since 723b7a2789
(vcs-svn: eliminate repo_tree structure, 2010-12-10).
This was noticed when including repository.h via cache.h as that has the
same function with a different signature.
Helped-by: Jonathan Nieder [off-list ref]
Signed-off-by: Stefan Beller <redacted>
---
It looks to me that this is a reduced duplicate of what brian posted
yesterday. The first two patches in the 6-patch series that you
commented on, I think, covers what this change wants to achieve and
probably a lot more. I've merged those two already to 'next' and
was about to push the result out.
I just sent
https://public-inbox.org/git/20170822233732.GX13924@aiede.mtv.corp.google.com/
to fix this more thoroughly. I can rebase on top of bc/vcs-svn-cleanup
if that is helpful --- just say the word.
Thanks,
Jonathan