Re: [PATCH v4 2/3] builtin/branch: stop supporting the use of --set-upstream option

Kaartic Sivaraam [off-list ref] writes:

On Friday 18 August 2017 01:25 AM, Junio C Hamano wrote:

quoted

Martin Ågren [off-list ref] writes:

quoted

On 17 August 2017 at 04:54, Kaartic Sivaraam
[off-list ref] wrote:

quoted

Helped-by: Martin Ågren [off-list ref],  Junio C Hamano [off-list ref]
Signed-off-by: Kaartic Sivaraam <redacted>

I didn't expect a "Helped-by", all I did was to give some random
comments. :-) I'm not so sure about the comma-separation, that seems to
be a first in the project.

I didn't either ;-)

The line looks odd so I'll remove it while queuing.

Thanks for noticing.

I should have been better with my wordings :) How about converting that
line into two 'Suggestions-by:' or 'Reviewed-by:' ?

I personally do not think either is needed for those small things we
saw in the discussion.

Unless Martin feels strongly about it, that is.

Thanks.

On 18 August 2017 at 18:30, Junio C Hamano [off-list ref] wrote:

Kaartic Sivaraam [off-list ref] writes:

quoted

On Friday 18 August 2017 01:25 AM, Junio C Hamano wrote:

quoted

Martin Ågren [off-list ref] writes:

quoted

On 17 August 2017 at 04:54, Kaartic Sivaraam
[off-list ref] wrote:

quoted

Helped-by: Martin Ågren [off-list ref],  Junio C Hamano [off-list ref]
Signed-off-by: Kaartic Sivaraam <redacted>

I didn't expect a "Helped-by", all I did was to give some random
comments. :-) I'm not so sure about the comma-separation, that seems to
be a first in the project.

I didn't either ;-)

The line looks odd so I'll remove it while queuing.

Thanks for noticing.

I should have been better with my wordings :) How about converting that
line into two 'Suggestions-by:' or 'Reviewed-by:' ?

I personally do not think either is needed for those small things we
saw in the discussion.

Unless Martin feels strongly about it, that is.

No, no strong feelings. Thanks.