Re: [PATCH v3 1/2 / RFC] builtin/branch: stop supporting the use of --set-upstream option

From: Junio C Hamano <hidden>
Date: 2017-08-15 18:58:23

Kaartic Sivaraam [off-list ref] writes:

1. Duplicate the check done in 'builtin/branch.c' in
'builtin/checkout.c'. This doesn't
    sound good to me.

Doesn't sound good to me, either.  Some refactoring to make it
easier to reuse it from the new caller would be necessary.

From: Kaartic Sivaraam <hidden>
Date: 2017-08-16 18:12:25

On Wednesday 16 August 2017 12:28 AM, Junio C Hamano wrote:

Some refactoring to make it easier to reuse it from the new caller 
would be necessary.

Sorry but I think I don't get that correctly. What's the "new caller" 
being referred to here?
What should be refactored?

---
Kaartic