[PATCH] refs: use skip_prefix() in ref_is_hidden()
From: Christian Couder <hidden>
Date: 2017-07-21 09:58:35
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Christian Couder <hidden>
Date: 2017-07-21 09:58:35
Subsystem:
the rest · Maintainer:
Linus Torvalds
This saves one line, makes the code a bit easier to understand and perhaps a bit faster too. Signed-off-by: Christian Couder <redacted> --- refs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index ba22f4acef..15cb36d426 100644
--- a/refs.c
+++ b/refs.c@@ -1160,7 +1160,7 @@ int ref_is_hidden(const char *refname, const char *refname_full) const char *match = hide_refs->items[i].string; const char *subject; int neg = 0; - int len; + const char *p; if (*match == '!') { neg = 1;
@@ -1175,10 +1175,9 @@ int ref_is_hidden(const char *refname, const char *refname_full) } /* refname can be NULL when namespaces are used. */ - if (!subject || !starts_with(subject, match)) + if (!subject || !skip_prefix(subject, match, &p)) continue; - len = strlen(match); - if (!subject[len] || subject[len] == '/') + if (!*p || *p == '/') return !neg; } return 0;
--
2.14.0.rc0.26.g981adb928e.dirty