Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

2 messages, 2 authors, 2017-06-10 · open the first message on its own page

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

From: Junio C Hamano <hidden>
Date: 2017-06-10 01:58:03

Junio C Hamano [off-list ref] writes:
Ævar Arnfjörð Bjarmason  [off-list ref] writes:
quoted
Add a test which covers a blindspot in how these tests should assert
that negated character classes are allowed or not allowed to match "/"
in certain circumstances.
Please make this a bit more explicit, something like

	A negated character class that does not include '/',
	e.g. [^a-z],
oops.  I think the class includes '/'; please excuse loose logic in
a "something like" meant as an illustration to show the level of
details expected ;-)

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2017-06-10 11:31:52

On Sat, Jun 10 2017, Junio C. Hamano jotted:
Junio C Hamano [off-list ref] writes:
quoted
Ævar Arnfjörð Bjarmason  [off-list ref] writes:
quoted
Add a test which covers a blindspot in how these tests should assert
that negated character classes are allowed or not allowed to match "/"
in certain circumstances.
Please make this a bit more explicit, something like

	A negated character class that does not include '/',
	e.g. [^a-z],
oops.  I think the class includes '/'; please excuse loose logic in
a "something like" meant as an illustration to show the level of
details expected ;-)
Thanks for the feedback. Sorry I'm slightly confused still (after
reading this over a couple of times), are you OK with this patch/commit
message as-is or would you still like some clarification there?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help