[PATCH] name-rev: change a "long" variable to timestamp_t

Subsystems: the rest

STALE3441d

2 messages, 2 authors, 2017-05-22 · open the first message on its own page

[PATCH] name-rev: change a "long" variable to timestamp_t

From: Junio C Hamano <hidden>
Date: 2017-05-20 05:47:47

Earlier dddbad72 ("timestamp_t: a new data type for timestamps",
2017-04-26) updated all in-core variables, fields and function
return values that are used to store "seconds since epoch" to a new
type timestamp_t.  Unfortunately one variable "cutoff", which is
used to keep track of the oldest timestamp of commit we saw on the
command line, was "long", and left behind.

Update it to timestamp_t as well.

Signed-off-by: Junio C Hamano <redacted>
---

 * Noticed while merging the topic 'mg/name-rev-debug' to 'pu'.

 builtin/name-rev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/name-rev.c b/builtin/name-rev.c
index 4437475017..1f6fcae121 100644
--- a/builtin/name-rev.c
+++ b/builtin/name-rev.c
@@ -15,7 +15,7 @@ typedef struct rev_name {
 	int distance;
 } rev_name;
 
-static long cutoff = LONG_MAX;
+static timestamp_t cutoff = TIME_MAX;
 
 /* How many generations are maximally preferred over _one_ merge traversal? */
 #define MERGE_TRAVERSAL_WEIGHT 65535
-- 
2.13.0-439-gd4feae47b3

Re: [PATCH] name-rev: change a "long" variable to timestamp_t

From: Johannes Schindelin <hidden>
Date: 2017-05-22 13:40:03

Hi Junio,

On Sat, 20 May 2017, Junio C Hamano wrote:
Earlier dddbad72 ("timestamp_t: a new data type for timestamps",
2017-04-26) updated all in-core variables, fields and function
return values that are used to store "seconds since epoch" to a new
type timestamp_t.  Unfortunately one variable "cutoff", which is
used to keep track of the oldest timestamp of commit we saw on the
command line, was "long", and left behind.

Update it to timestamp_t as well.

Signed-off-by: Junio C Hamano <redacted>
Obviously correct. Thanks.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help