Re: [GSoC][PATCH v4 2/4] dir: add directory_exists

1 message, 1 author, 2017-03-16 · open the first message on its own page

Re: [GSoC][PATCH v4 2/4] dir: add directory_exists

From: Junio C Hamano <hidden>
Date: 2017-03-16 18:26:21

Junio C Hamano [off-list ref] writes:
Devin Lehmacher [off-list ref] writes:
quoted
+int directory_exists(const char *path)
+{
+	struct stat sb;
+	int ret = lstat(path, &sb);
+	return ret == 0 && S_ISDIR(sb.st_mode);
+}
I am not a great fan of using file_exists() [*1*] on anything other
than paths in the working tree (i.e. in preparation for checking
things out of or into the index), as ...
...
[Footnote]

*1* ... and friends, like safe_create_leading_directories().
I actually got things mixed up.  safe-create-leading-directories is
to be used only for paths inside .git/ (i.e. not for working tree
files, but for things like ".git/refs/heads/foo" when creating a
branch called foo/bar).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help