# Re: \[GSoC\]\[PATCH/RFC v3 2/3\] credential-cache: use XDG\_CACHE\_HOME for socket

- From: Junio C Hamano \<hidden\>
- Date: 2017-03-14 01:50:17 
- List: git
- Page: https://ratatoskr.run/git/2017/03/7712075
- Thread: https://ratatoskr.run/git/2017/03/7712075/t.md

```text
Devin Lehmacher [ref] writes:

> Signed-off-by: Devin Lehmacher <redacted>
> Reviewed-by: Junio C Hamano, Jeff King

The last line is premature; neither of us reviewed this exact
version and haven't checked if all the issues we mentioned in the
previous review have been addressed.


> +static char *get_socket_path(void) {

Compare ths line with how cmd_main() below is declared.  Notice
any difference?  We begin our functions like this:

	static char *get_socket_path(void)
	{

```