Re: Cross-referencing the Git mailing list archive with their corresponding commits in `pu`

3 messages, 3 authors, 2017-02-09 · open the first message on its own page

Re: Cross-referencing the Git mailing list archive with their corresponding commits in `pu`

From: Junio C Hamano <hidden>
Date: 2017-02-06 19:10:59

Johannes Schindelin [off-list ref] writes:
So I thought maybe the From: line (from the body, if available, otherwise
from the header) in conjunction with the "Date:" header would work.
FYI, I use a post-applypatch hook to populate refs/notes/amlog notes
tree when I queue a new patch; I am not sure how well the notes in
it are preserved across rebases, but it could be a good starting
point.  The notes tree is mirrored at git://github.com/git/gitster
repository.

E.g.

$ git show --notes=amlog --stat
commit 2488dcab22cee343fe35d9951160f0966a45fdb3
Author: Patrick Steinhardt [off-list ref]
Date:   Mon Feb 6 14:13:59 2017 +0100

    worktree: fix option descriptions for `prune`
    
    The `verbose` and `expire` options of the `git worktree prune`
    subcommand have wrong descriptions in that they pretend to relate to
    objects. But as the git-worktree(1) correctly states, these options have
    nothing to do with objects but only with worktrees. Fix the description
    accordingly.
    
    Signed-off-by: Patrick Steinhardt [off-list ref]
    Signed-off-by: Junio C Hamano [off-list ref]

Notes (amlog):
    Message-Id: [off-list ref]

 builtin/worktree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Re: Cross-referencing the Git mailing list archive with their corresponding commits in `pu`

From: Lars Schneider <hidden>
Date: 2017-02-09 14:11:48

On 06 Feb 2017, at 20:10, Junio C Hamano [off-list ref] wrote:

Johannes Schindelin [off-list ref] writes:
quoted
So I thought maybe the From: line (from the body, if available, otherwise
from the header) in conjunction with the "Date:" header would work.
FYI, I use a post-applypatch hook to populate refs/notes/amlog notes
tree when I queue a new patch; I am not sure how well the notes in
it are preserved across rebases, but it could be a good starting
point.  The notes tree is mirrored at git://github.com/git/gitster
repository.

E.g.

$ git show --notes=amlog --stat
That's super useful! Thanks for the pointer!
Wouldn't it make sense to push these notes to github.com/git/git ?

- Lars

Re: Cross-referencing the Git mailing list archive with their corresponding commits in `pu`

From: Johannes Schindelin <hidden>
Date: 2017-02-09 22:12:24

Hi Lars,

On Thu, 9 Feb 2017, Lars Schneider wrote:
quoted
On 06 Feb 2017, at 20:10, Junio C Hamano [off-list ref] wrote:

Johannes Schindelin [off-list ref] writes:
quoted
So I thought maybe the From: line (from the body, if available,
otherwise from the header) in conjunction with the "Date:" header
would work.
FYI, I use a post-applypatch hook to populate refs/notes/amlog notes
tree when I queue a new patch; I am not sure how well the notes in it
are preserved across rebases, but it could be a good starting point.
The notes tree is mirrored at git://github.com/git/gitster repository.

E.g.

$ git show --notes=amlog --stat
That's super useful! Thanks for the pointer!
Wouldn't it make sense to push these notes to github.com/git/git ?
I am not quite sure about that. It is in a different namespace than what
is usually cloned, and it currently adds 8MB to the download (there are
"amlog" and "commits", the latter clearly being a sandbox).

While I am thankful that there is at least some information available for
patches integrated into `pu` since Nov 1 2016, the format is probably not
stable (we are talking about free-form notes, after all), and it still
does not help with catching the case where new patch series iterations (or
in some case, new patch series, period) are missed.

Make no mistake, it will be a huge undertaking to develop a tool that
helps with the management of patch series on top of the mailing list
driven patch review process. And even in the best case, it may be simply
too hard for an automated tool to figure things out e.g. when Peff or
Junio paste a tangentially related diff into a thread.

In the end, what I *really* would love to have is a system where you can
easily query "which reviewer comments on *any* of my patch series are new,
or still unaddressed?", and "in what way was my patch modified relative to
the latest version I submitted?". It may actually be impossible to create
such a tool, as it cannot invent information/cross-references that it does
not have nor can deduce from available data.

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help