Jacob Keller [off-list ref] writes:
From: Jacob Keller <redacted>
** v3 fixes a minor typo in one of the test cases, so please ignore v2
I left the interdiff as between v1 and v3 instead of v2 **
Very much appreciated.
I just finished reading this round through and didn't have any major
issues. I sent comments on the way the feature is explained to the
end users and history readers, though.
Thanks.
On Wed, Jan 18, 2017 at 12:18 PM, Junio C Hamano [off-list ref] wrote:
Jacob Keller [off-list ref] writes:
quoted
From: Jacob Keller <redacted>
** v3 fixes a minor typo in one of the test cases, so please ignore v2
I left the interdiff as between v1 and v3 instead of v2 **
Very much appreciated.
I just finished reading this round through and didn't have any major
issues. I sent comments on the way the feature is explained to the
end users and history readers, though.
Thanks.
Ok. I am currently taking a look at the exclude_list that was
mentioned, and I will see if it makes sense to go that route. If we
do, it would open up a way to make the git-describe logic similar to
git-log (which is probably good), and if we want to do this, it's best
to do it now before we add any additional arguments (ie: before we
create a conflicting user interface).
Thanks,
Jake