Re: [PATCH 2/4] t1000: modernize style

2 messages, 2 authors, 2017-01-10 · open the first message on its own page

Re: [PATCH 2/4] t1000: modernize style

From: Junio C Hamano <hidden>
Date: 2017-01-10 20:38:21

Stefan Beller [off-list ref] writes:
The preferred style in tests seems to be
s/seems to be/is/;
test_expect_success 'short description, ended by 2 single quotes' '
	here comes the test &&
	and chains over many lines &&
	ended by a quote
'
Thanks.  This is way overdue.  During the time the script has been
dormant for more than two years, we should have done this.

Re: [PATCH 2/4] t1000: modernize style

From: Stefan Beller <hidden>
Date: 2017-01-10 20:43:39

On Tue, Jan 10, 2017 at 12:37 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:
quoted
The preferred style in tests seems to be
s/seems to be/is/;
If this is the only nit, mind to fix up the commit message locally?
(I was even unsure if we want to have this patch as part
of a larger series, as it is just refactoring for the sake of refactoring,
i.e. t1000 doesn't see a new test in this series, only t1001 does)
quoted
test_expect_success 'short description, ended by 2 single quotes' '
      here comes the test &&
      and chains over many lines &&
      ended by a quote
'
Thanks.  This is way overdue.  During the time the script has been
dormant for more than two years, we should have done this.
agreed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help