Re: [PATCH] don't use test_must_fail with grep

Pranit Bauva [off-list ref] writes:

Hey Johannes,

On Sun, Jan 1, 2017 at 8:20 PM, Johannes Sixt [off-list ref] wrote:

quoted

which makes me wonder: Is the message that we do expect not to occur
actually printed on stdout? It sounds much more like an error message, i.e.,
text that is printed on stderr. Wouldn't we need this?

        git p4 commit >actual 2>&1 &&
        ! grep "git author.*does not match" actual &&

-- Hannes

This seems better! Since I am at it, I can remove the traces of pipes
in an another patch.

Regards,
Pranit Bauva

I see v3 that has 2>&1 but according to Luke's comment ("the message
comes from cat"), it shouldn't be there?  I am behind clearing the
backlog in my mailbox and I could tweak it out from v3 while
queuing, or I may forget about it after looking at other topics ;-)
in which case you may want to send v4 with the fix?

Hey Junio,

On Sun, Jan 8, 2017 at 2:48 AM, Junio C Hamano [off-list ref] wrote:

I see v3 that has 2>&1 but according to Luke's comment ("the message
comes from cat"), it shouldn't be there?  I am behind clearing the
backlog in my mailbox and I could tweak it out from v3 while
queuing, or I may forget about it after looking at other topics ;-)
in which case you may want to send v4 with the fix?

Yeah sure! No problem! :)

Regards,
Pranit Bauva