Re: [PATCH] branch_get_push: do not segfault when HEAD is detached

Jeff King [off-list ref] writes:

On Fri, Jan 06, 2017 at 08:09:32PM -0500, Kyle Meyer wrote:

quoted

quoted

$ git grep -c HEAD^{} junio/pu -- t/
junio/pu:t/t3200-branch.sh:3

Maybe use HEAD^0 just for consistency?

Yes, thanks for pointing that out.

The other option is just "git checkout --detach", which is also used in
the test suite. I tend to prefer it because it's a little more obvious
to a reader.

True, that does seem clearer.  Seems I should've waited a bit before
sending out v2.

--
Kyle

On Fri, Jan 06, 2017 at 08:19:53PM -0500, Kyle Meyer wrote:

quoted

The other option is just "git checkout --detach", which is also used in
the test suite. I tend to prefer it because it's a little more obvious
to a reader.

True, that does seem clearer.  Seems I should've waited a bit before
sending out v2.

I think it's OK either way. Junio can also mark it up while applying,
too, if he has a preference.

-Peff