Re: [RFC for GIT] pull-request: add praise to people doing QA
From: Junio C Hamano <hidden>
Date: 2017-01-19 21:26:58
2 messages, 2 authors, 2017-01-19 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2017-01-19 21:26:58
Wolfram Sang [off-list ref] writes:
I didn't know about trailers before. As I undestand it, I could use "Tested-by" as the key, and the commit subject as the value. This list then could be parsed and brought into proper output shape. It would simplify the subject parsing, but most things my AWK script currently does would still need to stay or to be reimplemented (extracting names from tags, creating arrays of tags given by $name). Am I correct?
That is not exactly what I had in mind. I was wondering if we can do without any external script, implementing the logic you added inside shortlog with an extra option that triggers the whole thing, which may call into the same trailers API as used by the interpret-trailers command to do the parsing and picking out parts.
From: Wolfram Sang <hidden>
Date: 2017-01-19 22:03:03
quoted
I didn't know about trailers before. As I undestand it, I could use "Tested-by" as the key, and the commit subject as the value. This list then could be parsed and brought into proper output shape. It would simplify the subject parsing, but most things my AWK script currently does would still need to stay or to be reimplemented (extracting names from tags, creating arrays of tags given by $name). Am I correct?That is not exactly what I had in mind. I was wondering if we can do without any external script, implementing the logic you added inside shortlog with an extra option that triggers the whole thing, which may call into the same trailers API as used by the interpret-trailers command to do the parsing and picking out parts.
Sorry for being unclear. That's what I meant with "or to be reimplemented". I should have added "in C". I am afraid this also requires more time than I am willing to spend on this issue. Seems my hack is going to stay for a while here. However, thank you for your time and assisting me with pointers!