Re: [PATCH] allow git-p4 to create shelved changelists

2 messages, 2 authors, 2016-11-29 · open the first message on its own page

Re: [PATCH] allow git-p4 to create shelved changelists

From: Junio C Hamano <hidden>
Date: 2016-11-28 19:06:12

Vinicius Kursancew [off-list ref] writes:
This patch adds a "--shelve" option to the submit subcommand, it will
save the changes to a perforce shelve instead of commiting them.

Vinicius Kursancew (1):
  git-p4: allow submit to create shelved changelists.

 Documentation/git-p4.txt |  5 +++++
 git-p4.py                | 36 ++++++++++++++++++++++--------------
 t/t9807-git-p4-submit.sh | 31 +++++++++++++++++++++++++++++++
 3 files changed, 58 insertions(+), 14 deletions(-)
Thanks, but I am a wrong person to review this change, so I'll
summon two people who appear in "git shortlog --since=18.months"
output to help review it.

Re: [PATCH] allow git-p4 to create shelved changelists

From: Luke Diamand <hidden>
Date: 2016-11-29 12:47:29

On 28 November 2016 at 19:06, Junio C Hamano [off-list ref] wrote:
Vinicius Kursancew [off-list ref] writes:
quoted
This patch adds a "--shelve" option to the submit subcommand, it will
save the changes to a perforce shelve instead of commiting them.
Looks good to me, thanks!

Works a treat.

Ack.
quoted
Vinicius Kursancew (1):
  git-p4: allow submit to create shelved changelists.

 Documentation/git-p4.txt |  5 +++++
 git-p4.py                | 36 ++++++++++++++++++++++--------------
 t/t9807-git-p4-submit.sh | 31 +++++++++++++++++++++++++++++++
 3 files changed, 58 insertions(+), 14 deletions(-)
Thanks, but I am a wrong person to review this change, so I'll
summon two people who appear in "git shortlog --since=18.months"
output to help review it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help