Re: [PATCH] t6026-merge-attr: don't fail if sleep exits early

On Nov 09 2016, Johannes Schindelin [off-list ref] wrote:

The reason why we do not ignore kill errors is that we want to make sure
that the script *actually ran*. Otherwise, the thing we need to test here
does not necessarily get tested.

That can be tested by looking for the pid file.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

On Wed, Nov 09, 2016 at 03:36:40PM +0100, Andreas Schwab wrote:

On Nov 09 2016, Johannes Schindelin [off-list ref] wrote:

quoted

The reason why we do not ignore kill errors is that we want to make sure
that the script *actually ran*. Otherwise, the thing we need to test here
does not necessarily get tested.

That can be tested by looking for the pid file.

I agree that makes the intent a lot more obvious. Having a necessary
condition of the test stuffed into a test_when_finished block seems
counter-intuitive.

-Peff