Re: [PATCH v3 0/5] Add --format to tag verification

2 messages, 2 authors, 2016-10-03 · open the first message on its own page

Re: [PATCH v3 0/5] Add --format to tag verification

From: Junio C Hamano <hidden>
Date: 2016-09-30 23:28:56

What is in the patch series looked more or less good to me.  Lukas's
sirname was still P in [3/5], a patch in [4/5] added an unnecssary
blank line before git_verify_tag_config() and also a local variable
declaration for "char *fmt_pretty" was indented funnily, but none of
these were something I couldn't fix up locally.

I however notice that there is no new tests to protect these two new
features from future breakages.  Perhaps you want to add some in
[6/5]?

Thanks.


Re: [PATCH v3 0/5] Add --format to tag verification

From: Santiago Torres <hidden>
Date: 2016-10-03 14:49:12

Hi, Junio. 
I however notice that there is no new tests to protect these two new
features from future breakages.  Perhaps you want to add some in
[6/5]?
I'll be working on this. I spent some time looking around for example
tests for format. Are there any that I should pay special attention to?
(I'm looking at t7004 mostly right now).

Thanks!
-Santiago.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help