Re: [PATCH v4 3/4] read-cache: introduce chmod_index_entry

Subsystems: the rest

2 messages, 2 authors, 2016-09-15 · open the first message on its own page

Re: [PATCH v4 3/4] read-cache: introduce chmod_index_entry

From: Junio C Hamano <hidden>
Date: 2016-09-14 22:54:46

I've queued this trivial SQUASH??? on top, which I think should be
squashed into 3/4.

Thanks.


 read-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/read-cache.c b/read-cache.c
index 2445e30..c2b2e97 100644
--- a/read-cache.c
+++ b/read-cache.c

@@ -779,7 +779,7 @@ int chmod_index_entry(struct index_state *istate, struct cache_entry *ce,
 	default:
 		return -2;
 	}
-	cache_tree_invalidate_path(&the_index, ce->name);
+	cache_tree_invalidate_path(istate, ce->name);
 	ce->ce_flags |= CE_UPDATE_IN_BASE;
 	istate->cache_changed |= CE_ENTRY_CHANGED;

-- 
2.10.0-458-g8cce42d

Re: [PATCH v4 3/4] read-cache: introduce chmod_index_entry

From: Thomas Gummerer <hidden>
Date: 2016-09-15 18:48:57

On 09/14, Junio C Hamano wrote:

I've queued this trivial SQUASH??? on top, which I think should be
squashed into 3/4.

Yeah, I missed this.  The SQUASH??? definitely makes sense, would be
great if you could just squash that in.

Thanks.

Thanks the reviews and helping me getting the series in a good shape!

quoted hunk


 read-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/read-cache.c b/read-cache.c
index 2445e30..c2b2e97 100644
--- a/read-cache.c
+++ b/read-cache.c

@@ -779,7 +779,7 @@ int chmod_index_entry(struct index_state *istate, struct cache_entry *ce,
 	default:
 		return -2;
 	}
-	cache_tree_invalidate_path(&the_index, ce->name);
+	cache_tree_invalidate_path(istate, ce->name);
 	ce->ce_flags |= CE_UPDATE_IN_BASE;
 	istate->cache_changed |= CE_ENTRY_CHANGED;

-- 
2.10.0-458-g8cce42d

-- 
Thomas

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help