[PATCH] pkt-line: mark a file-local symbol static

Subsystems: the rest

STALE3615d

2 messages, 2 authors, 2016-09-15 · open the first message on its own page

[PATCH] pkt-line: mark a file-local symbol static

From: Ramsay Jones <hidden>
Date: 2016-09-14 13:31:48

Signed-off-by: Ramsay Jones <redacted>
---

Hi Lars,

If you need to re-roll your 'ls/filter-process' branch, could you
please squash this into the relevant patch; commit 2afd9b22
("pkt-line: add packet_write_gently()", 08-09-2016).

[If you think the symbol should be public (I don't), then add a
suitable declaration to pkt-line.h instead.]

Thanks!

ATB,
Ramsay Jones

 pkt-line.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c
index 538e35f..4900fc0 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -181,7 +181,7 @@ int packet_write_fmt_gently(int fd, const char *fmt, ...)
 	return status;
 }
 
-int packet_write_gently(const int fd_out, const char *buf, size_t size)
+static int packet_write_gently(const int fd_out, const char *buf, size_t size)
 {
 	static char packet_write_buffer[LARGE_PACKET_MAX];
 
-- 
2.10.0

Re: [PATCH] pkt-line: mark a file-local symbol static

From: Lars Schneider <hidden>
Date: 2016-09-15 19:36:10

On 14 Sep 2016, at 14:31, Ramsay Jones [off-list ref] wrote:


Signed-off-by: Ramsay Jones <redacted>
---

Hi Lars,

If you need to re-roll your 'ls/filter-process' branch, could you
please squash this into the relevant patch; commit 2afd9b22
("pkt-line: add packet_write_gently()", 08-09-2016).

[...]
-int packet_write_gently(const int fd_out, const char *buf, size_t size)
+static int packet_write_gently(const int fd_out, const char *buf, size_t size)
{
	static char packet_write_buffer[LARGE_PACKET_MAX];
Done!

Thank you,
Lars
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help