[PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers

Subsystems: the rest

STALE3618d

2 messages, 2 authors, 2016-09-14 · open the first message on its own page

[PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers

From: Mike Ralphson <hidden>
Date: 2016-09-14 06:41:03

Two instances of %ld being used for unsigned longs

Signed-off-by: Mike Ralphson <redacted>
---
 vcs-svn/fast_export.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c
index bd0f2c2..97cba39 100644
--- a/vcs-svn/fast_export.c
+++ b/vcs-svn/fast_export.c
@@ -73,7 +73,7 @@ void fast_export_begin_note(uint32_t revision, const char *author,
 	static int firstnote = 1;
 	size_t loglen = strlen(log);
 	printf("commit %s\n", note_ref);
-	printf("committer %s <%s@%s> %ld +0000\n", author, author, "local", timestamp);
+	printf("committer %s <%s@%s> %lu +0000\n", author, author, "local", timestamp);
 	printf("data %"PRIuMAX"\n", (uintmax_t)loglen);
 	fwrite(log, loglen, 1, stdout);
 	if (firstnote) {
@@ -107,7 +107,7 @@ void fast_export_begin_commit(uint32_t revision, const char *author,
 	}
 	printf("commit %s\n", local_ref);
 	printf("mark :%"PRIu32"\n", revision);
-	printf("committer %s <%s@%s> %ld +0000\n",
+	printf("committer %s <%s@%s> %lu +0000\n",
 		   *author ? author : "nobody",
 		   *author ? author : "nobody",
 		   *uuid ? uuid : "local", timestamp);

--
https://github.com/git/git/pull/293

Re: [PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers

From: Jeff King <hidden>
Date: 2016-09-14 19:11:19

On Wed, Sep 14, 2016 at 06:40:57AM +0000, Mike Ralphson wrote:
Two instances of %ld being used for unsigned longs
Obviously this is an improvement, but I'm kind of surprised that
compiler warnings didn't flag this. I couldn't find a "-W" combination
that noticed, though (at least not with gcc 6).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help