# Re: \[PATCH v2 10/14\] sequencer: lib'ify read\_populate\_opts()

- From: Junio C Hamano \<hidden\>
- Date: 2016-08-29 21:14:36 
- List: git
- Page: https://ratatoskr.run/git/2016/08/7694634
- Thread: https://ratatoskr.run/git/2016/08/7694634/t.md

```text
Junio C Hamano [ref] writes:

>> +	if (git_config_from_file(populate_opts_cb, git_path_opts_file(), *opts) < 0)
>> +		return error(_("Malformed options sheet: %s"),
>> +			git_path_opts_file());
>> +	return 0;
>
> As discussed, perhaps have a comment immediately before calling
> config-from-file that says that the call could die when it is fed a
> syntactically broken file, but we ignore it for now because we will
> be writing the file we have written, or something?

Obviously we will be _READING_ here ;-)
```