# Re: \[PATCH 2/2\] checkout: do not mention detach advice for explicit --detach option

- From: Junio C Hamano \<hidden\>
- Date: 2016-08-15 21:05:34 
- List: git
- Page: https://ratatoskr.run/git/2016/08/7693531
- Thread: https://ratatoskr.run/git/2016/08/7693531/t.md

```text
Jeff King [ref] writes:

> I don't think doing it this way is _wrong_. It just feels sort of
> pointlessly over-engineered. It's also a little weird that all of the:
>
>   if (advice_foo)
>
> will trigger because "advice_foo" is set to -1. I think it does the
> right thing, but it feels like a bug (the value is now a tri-state, and
> we silently collapse two states into one).

Guilty as charged.  I do agree that this is over-engineered.
```