Re: [PATCH v1 2/3] doc: rebase: fixup! can take an object name

2 messages, 2 authors, 2016-08-14 · open the first message on its own page

Re: [PATCH v1 2/3] doc: rebase: fixup! can take an object name

From: Junio C Hamano <hidden>
Date: 2016-08-14 22:11:55

Philip Oakley [off-list ref] writes:
Since 68d5d03 (rebase: teach --autosquash to match on sha1 in addition
to message, 2010-11-04) the commit subject can refer directly to the
destination object hash as a single word.)...
That's not an object hash but an object name (see glossary); you got
it right in the actual patch text, though ;-).
quoted hunk
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 0387b40..66b789a 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -421,7 +421,8 @@ without an explicit `--interactive`.
 --no-autosquash::
 	When the commit log message begins with "squash! ..." (or
 	"fixup! ..."), and there is a commit whose title begins with
-	the same ..., automatically modify the todo list of rebase -i
+	the same "..." message, or a commit object name (standalone),
+	automatically modify the todo list of rebase -i
What's "(standalone)"?  I can understand the updated text and agree
that it is better than the original without that part, though.
 	so that the commit marked for squashing comes right after the
 	commit to be modified, and change the action of the moved
 	commit from `pick` to `squash` (or `fixup`).  Ignores subsequent

Re: [PATCH v1 2/3] doc: rebase: fixup! can take an object name

From: Philip Oakley <hidden>
Date: 2016-08-14 23:00:21

From: "Junio C Hamano" <redacted>
Philip Oakley [off-list ref] writes:
quoted
Since 68d5d03 (rebase: teach --autosquash to match on sha1 in addition
to message, 2010-11-04) the commit subject can refer directly to the
destination object hash as a single word.)...
That's not an object hash but an object name (see glossary); you got
it right in the actual patch text, though ;-).
As noted in 1/3, the glossary also needs a fix (for those who read it) to 
make sure the name-value confusion is distinguished, with the potential 
'object names' (colloquial)  being via (git) 'revisions', while  the 
cannonical object name is the (oid) sha1 hash. Somehow folk need pointing at 
the (broad) ways of spelling commit names rather than just the narrow sha. A 
bit of a finger and the moon problem.
quoted
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 0387b40..66b789a 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -421,7 +421,8 @@ without an explicit `--interactive`.
 --no-autosquash::
 When the commit log message begins with "squash! ..." (or
 "fixup! ..."), and there is a commit whose title begins with
- the same ..., automatically modify the todo list of rebase -i
+ the same "..." message, or a commit object name (standalone),
+ automatically modify the todo list of rebase -i
What's "(standalone)"?  I can understand the updated text and agree
that it is better than the original without that part, though.
the 'standalone' is that it must be a single (standalone) word on the 
subject line immediately after the "fixup! "(s).

communicationg that one cannot have any extra textual notes after that word 
was the issue that 'standalone' tried to address.

--
Philip 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help