# Re: \[PATCH\] sha1\_file: don't malloc the whole compressed result when writing out objects

- From: Junio C Hamano \<hidden\>
- Date: 2016-08-13 23:25:33 
- List: git
- Page: https://ratatoskr.run/git/2016/08/7693296
- Thread: https://ratatoskr.run/git/2016/08/7693296/t.md

```text
Nicolas Pitre [ref] writes:

>> Having said all that, I like your approach better.  It is not worth paying
>> the price of unnecessary memcpy(3) that would _only_ help catching the
>> insanely artificial test case, but your patch strikes a good balance of
>> small overhead to catch the easier-to-trigger (either by stupidity, malice
>> or mistake) cases.
>
> I think it also catches the bad RAM case which is probably more common 
> too.

That is true; a broken RAM that returns unstable values will yield
different values between the time the first hash runs and the time the
deflate loop runs will trigger the safety.
```