[TopGit PATCH] pre-commit: check .topdeps for valid branches

Signed-off-by: Bert Wesarg <redacted>

---
 hooks/pre-commit.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
index 8e05a4e..1eae2e8 100644
--- a/hooks/pre-commit.sh
+++ b/hooks/pre-commit.sh

@@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }
 /^[^@ +-]/ { in_hunk = 0; }
 ' |
 	while read newly_added; do
+		ref_exists "$newly_added" ||
+			die "Invalid branch as dependent: $newly_added"
+
 		# deps can be non-tgish but we can't run recurse_deps() on them
 		ref_exists "refs/top-bases/$newly_added" ||
 			continue

-- 
tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)

Hi Bert,

this patch doesn't apply to my branch.  I'd say you didn't send out
bw/check-for-dep-cycle (or I oversaw it).

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

2009/6/4 Uwe Kleine-König [off-list ref]:

Hi Bert,

quoted

diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
index 8e05a4e..1eae2e8 100644
--- a/hooks/pre-commit.sh
+++ b/hooks/pre-commit.sh

@@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }

 /^[^@ +-]/ { in_hunk = 0; }
 ' |
      while read newly_added; do
+             ref_exists "$newly_added" ||
+                     die "Invalid branch as dependent: $newly_added"
+
              # deps can be non-tgish but we can't run recurse_deps() on them
              ref_exists "refs/top-bases/$newly_added" ||
                      continue
--
tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)

this patch doesn't apply to my branch.  I'd say you didn't send out
bw/check-for-dep-cycle (or I oversaw it).

I have forwarded it to you, but you may also want to clone my topgit tree at:

http://kgb2.thruhere.net/git/?p=bertw/topgit.git;a=summary

Now that repo.or.cz is up again, I will put this repo on this server next week.

Regards,
Bert

Best regards
Uwe